Skip to content
This repository has been archived by the owner on Mar 15, 2021. It is now read-only.

ignore events with pubsub; add protobuf serializer #97

Merged
merged 5 commits into from
Nov 26, 2018

Conversation

dmichel1
Copy link
Contributor

Two commits:

  1. Don't publish events to pubsub since we don't support them
  2. Add protobuf metric serializer! Its more cpu and space efficient. It reduces the serialized size of a metric by 18%.

@jsferrei @lmuhlha @hexedpackets

don’t sent events into the metrics pipeline
@lmuhlha
Copy link
Member

lmuhlha commented Nov 21, 2018

👍

@dmichel1 dmichel1 force-pushed the master branch 2 times, most recently from 216966d to 4607594 Compare November 25, 2018 14:57
Add a protobuf serializer that is more space and cpu efficient.
A JSON null value is being translated to a “null” string.

Was supposed to be fixed in FasterXML/jackson-databind#1842 but it doesn’t appear to be.
A json field with a null value was being serialized to a “null” string.
Which has support support for Java 11.
@dmichel1 dmichel1 merged commit 979eed0 into spotify:master Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants