Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Warn when parsing local config that refers to unsupported external credentials stores #797

Closed
declension opened this issue Jun 14, 2017 · 1 comment
Labels

Comments

@declension
Copy link

declension commented Jun 14, 2017

Description

This is very related to #657 (and originally dockerfile-maven #22).

The idea here is that a significant improvement for the end user is to simply recognise that their config.json uses an external credentials store that won't be supported, so fail fast, or at least output a warning message (e.g. it took me a long time to work out why my "image wasn't found" when the plugin despite docker build working fine when building the same image).

How to reproduce

Use a recent Docker client, that defaults to using the new secure external credentials store (OSX keychain, Windows Credentials store, D-Bus store etc)

What do you expect

Either for an execption to be thrown, or some sort of warning message about credentials not found / understood.

What happened instead

The client continues to authenticate with a null token, and fails (of course)

@stale
Copy link

stale bot commented Sep 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 24, 2018
@stale stale bot closed this as completed Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant