BREAKING CHANGE: Gradle Java Toolchains support for JavaExec and WorkerAPI #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpalcolea
force-pushed
the
toolchains-support
branch
from
dd44e0f to
89e8626
Compare
rpalcolea
force-pushed
the
toolchains-support
branch
from
89e8626 to
32f780b
Compare
rpalcolea
changed the title
|
LGTM except for the latest commit message not being a semantic versioning tag |
rpalcolea
changed the title
rpalcolea
force-pushed
the
toolchains-support
branch
from
32f780b to
2112597
Compare
rpalcolea
force-pushed
the
toolchains-support
branch
from
2112597 to
4173f41
Compare
|
Updated the commits and intentio nbehind the change 👍 |
jscancella
previously approved these changes
Jul 14, 2021
Merged
KengoTODA
added a commit
that referenced
this pull request
Sep 16, 2021
KengoTODA
added a commit
that referenced
this pull request
Sep 17, 2021
KengoTODA
added a commit
that referenced
this pull request
Sep 17, 2021
close #526 BREAKING CHANGE: Gradle v5 and v6 are now not supported
|
🎉 This issue has been resolved in version 5.0.0-beta.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
I've merged these changes to the |
|
🎉 This issue has been resolved in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of Toolchains for JVM Projects, there might be some folks that would like to leverage such feature when executing spotbugs either via worker api / javaexec / hybrid.
This pull request adds support for it. For now, this requires explicit opt-in via
If necessary, this could be default in the future but it seems like a safer approach to roll out this feature.
It will be interesting to keep an eye on gradle/gradle#16791
This is a breaking change as Toolchain support was introduced in Gradle 6.7 and became mature in 7.x
I suspect this should be rolled out as maybe 7.+ only? thoughts?