Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Square brackets in song names are parsed as markup by rich #1738

Closed
NicoWeio opened this issue Feb 13, 2023 · 0 comments · Fixed by #1696
Closed

Square brackets in song names are parsed as markup by rich #1738

NicoWeio opened this issue Feb 13, 2023 · 0 comments · Fixed by #1696
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed

Comments

@NicoWeio
Copy link
Contributor

NicoWeio commented Feb 13, 2023

System OS

Linux

Python Version

3.10 (CPython)

Install Source

GitHub

Install version / commit hash

4469221 (master branch) as well as ce04143 (dev branch)

Expected Behavior vs Actual Behavior

In the progress display as well as log messages, square brackets in song titles are not rendered properly, since rich tries to parse them as markup (like [green]). The saved files are – unsurprisingly – not affected.

Steps to reproduce - Ensure to include actual links!

Ensure you are running a "smart" terminal so that rich is used for printing.

spotdl "https://open.spotify.com/album/3xad1D7RkpRz7G6xNjuP44?si=oqEiNVMLQgCN3oEn1ezDqw"

Traceback

Downloaded "Crywolf - ": https://music.youtube.com/watch?v=EZvAVwVf5Mo
Downloaded "Crywolf - MEPHISTOPHELES": https://music.youtube.com/watch?v=NGWXXR2yFTY
Downloaded "Crywolf - FAWN": https://music.youtube.com/watch?v=Z6gc2AeCxRs
Downloaded "Crywolf - DRIP": https://music.youtube.com/watch?v=AVCCIx4Tm0I
Downloaded "Crywolf - ": https://music.youtube.com/watch?v=TgtpT1-lxpY
Downloaded "Crywolf - FOREIGN TONGUES": https://music.youtube.com/watch?v=uKEcu3sUW6M
Downloaded "Crywolf - ": https://music.youtube.com/watch?v=pcUSGhtEcgk
Downloaded "Crywolf - CEPHALOTUS": https://music.youtube.com/watch?v=hVfcXdcj3HY
Downloaded "Crywolf - ULTRAVIOLENT Pt. II ": https://music.youtube.com/watch?v=YfNkW4RnQc0
Downloaded "Crywolf - ": https://music.youtube.com/watch?v=K8o6dO_iaMA

[you get the idea…]

Other details

No response

@NicoWeio NicoWeio added the Bug Unexpected problem or unintended behavior that needs to be fixed label Feb 13, 2023
@xnetcat xnetcat linked a pull request Mar 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant