-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AVS-379] quadra cropping and scaling #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a few questions.
In Github CI why do we get ni_dec_fme_buffer_pool_free: NOT allocated
in most of the quadra unit tests?
https://github.com/sportsball-ai/av-rs/runs/7875049570?check_suite_focus=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple basic questions to start.
Sorry, forgot to answer this one. |
Agree! This appears not to be a problem. Thank you for looking into it. |
This updates the xcoder-quadra crate to use SW release 4.0 and adds hardware cropping and scaling functionality behind a nice, simple, safe API.
I'd recommend starting by looking at the usage in
test_transcoding
andtest_8k_ladder
.