Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVS-379] quadra cropping and scaling #115

Merged
merged 8 commits into from
Aug 17, 2022
Merged

Conversation

ccbrown
Copy link
Contributor

@ccbrown ccbrown commented Aug 17, 2022

This updates the xcoder-quadra crate to use SW release 4.0 and adds hardware cropping and scaling functionality behind a nice, simple, safe API.

I'd recommend starting by looking at the usage in test_transcoding and test_8k_ladder.

Copy link
Contributor

@lzuosym lzuosym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few questions.

In Github CI why do we get ni_dec_fme_buffer_pool_free: NOT allocated in most of the quadra unit tests?

https://github.com/sportsball-ai/av-rs/runs/7875049570?check_suite_focus=true

xcoder/xcoder-quadra/src/cropper.rs Outdated Show resolved Hide resolved
xcoder/xcoder-quadra/src/cropper.rs Outdated Show resolved Hide resolved
xcoder/xcoder-quadra/src/scaler.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@scottlamb scottlamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple basic questions to start.

xcoder/xcoder-quadra/src/decoder.rs Outdated Show resolved Hide resolved
xcoder/xcoder-quadra/src/decoder.rs Outdated Show resolved Hide resolved
@ccbrown ccbrown merged commit cb5fa48 into main Aug 17, 2022
@ccbrown ccbrown deleted the quadra-cropping-and-scaling branch August 17, 2022 23:09
@ccbrown
Copy link
Contributor Author

ccbrown commented Aug 18, 2022

LGTM. Just a few questions.

In Github CI why do we get ni_dec_fme_buffer_pool_free: NOT allocated in most of the quadra unit tests?

https://github.com/sportsball-ai/av-rs/runs/7875049570?check_suite_focus=true

Sorry, forgot to answer this one. ni_dec_fme_buffer_pool_free gets called unconditionally in ni_decoder_session_close. But we don't create a frame buffer pool since we're using hardware-only decoding. I'm not sure why they decided to log that message as an error, but it doesn't appear to be a problem or avoidable unless we want to create a frame buffer pool just to make that go away.

@lzuosym
Copy link
Contributor

lzuosym commented Aug 18, 2022

Sorry, forgot to answer this one. ni_dec_fme_buffer_pool_free gets called unconditionally in ni_decoder_session_close. But we don't create a frame buffer pool since we're using hardware-only decoding. I'm not sure why they decided to log that message as an error, but it doesn't appear to be a problem or avoidable unless we want to create a frame buffer pool just to make that go away.

Agree! This appears not to be a problem. Thank you for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants