Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse error messages #224

Merged
merged 4 commits into from
Feb 11, 2018
Merged

Collapse error messages #224

merged 4 commits into from
Feb 11, 2018

Conversation

jckdotim
Copy link
Contributor

@jckdotim jckdotim commented Feb 9, 2018 •
edited
Loading

In this patch, ValueError of deserialization shows all error messages at a time. (closes #168)

ValueError: family_name: '404' is not a string.
given_name: '503' is not a string.

@jckdotim jckdotim requested a review from dahlia February 9, 2018 16:57
@jckdotim jckdotim assigned dahlia and jckdotim and unassigned dahlia Feb 9, 2018
@jckdotim jckdotim added typ:bug Type: Bug/defect cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:python labels Feb 9, 2018
@dahlia dahlia merged commit cdf3f82 into nirum-lang:master Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanghyojun kanghyojun kanghyojun approved these changes

@dahlia dahlia dahlia approved these changes

Assignees

@jckdotim jckdotim

Labels
cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:python typ:bug Type: Bug/defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jckdotim @dahlia @kanghyojun