Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve document for statistics #223

Merged
merged 2 commits into from
Feb 10, 2018
Merged

Improve document for statistics #223

merged 2 commits into from
Feb 10, 2018

Conversation

AiOO
Copy link
Collaborator

@AiOO AiOO commented Feb 9, 2018 •
edited
Loading

오래된 PR의 먼지를 털어 올립니다.

  • 웹폰트가 안 나오는 문제를 수정합니다.
  • 타입 이름에 <code> 태그를 씌우는 대신 타입에 <code> 태그를 씌웁니다.
  • 메서드의 리턴 및 예외 정보를 아래에 나오도록 수정합니다.
  • 일부 디자인 수정

@AiOO AiOO self-assigned this Feb 9, 2018
@AiOO AiOO requested review from dahlia and kanghyojun February 9, 2018 16:02
kanghyojun
kanghyojun reviewed Feb 9, 2018
View reviewed changes
src/Nirum/Targets/Docs.hs
<span.type>type
<code>#{toNormalizedText ident}</code>
=
<h2><code>type</code> #{toNormalizedText ident} = #
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 #은 없어도되는거아닌가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

라인 끝에 공백 유지해주기 위한 코드입니당

@dahlia dahlia merged commit 8004dd6 into nirum-lang:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanghyojun kanghyojun kanghyojun approved these changes

@dahlia dahlia dahlia approved these changes

Assignees

@AiOO AiOO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AiOO @dahlia @kanghyojun