Several changes on RTTI metadata for Python target #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as I suggested in a comment before: nirum-lang/nirum-python#34 (comment)
The bug nirum-lang#185 is also applicable to union Tag enums.
dahlia
added
cmp:compiler
kanghyojun
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I suggested from deserialize_meta won't union properly nirum-python#34 (comment), now generated Python classes have
__nirum_type__attribute which contains one of'unboxed'/'enum'/'record'/'union'/'service'. The future versions of Python runtime library would be able to utilize this rather than diagnostics usingisinstance()/hasattr()queries. See also examples ontest_nirum_type().Also as I suggested from the same comment above, now union classes have an immutable map named
__nirum_tags__that keys are tags and values are class objects. See also examples ontest_nirum_tag_classes().Since the bug Python enum doesn't allow “mro” for member name #185 was also applicable to union tag enums, also fixed it. See also
test_union_reserved_keyword_for_tag()to reproduce the bug.