Rename mro not to overlap with Python keyword #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanghyojun
changed the title
dahlia
requested changes
Oct 24, 2017
src/Nirum/Targets/Python.hs
Outdated
| toEnumMemberName :: Name -> T.Text | ||
| toEnumMemberName name' = if attributeName `elem` memberKeywords | ||
| then T.snoc attributeName '_' | ||
| else attributeName |
src/Nirum/Targets/Python.hs
Outdated
| toEnumMemberName name' = if attributeName `elem` memberKeywords | ||
| then T.snoc attributeName '_' | ||
| else attributeName | ||
| where |
There was a problem hiding this comment.
This where doesn't have to be nested.
src/Nirum/Targets/Python.hs
Outdated
| memberKeywords = ["mro"] | ||
| toEnumMemberName :: Name -> T.Text | ||
| toEnumMemberName name' = if attributeName `elem` memberKeywords | ||
| then T.snoc attributeName '_' |
There was a problem hiding this comment.
How about making T.snoc an infix operator?
dahlia
previously approved these changes
Oct 24, 2017
kanghyojun
changed the title
dahlia
added
the
cmp:compiler
dahlia
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #185.
Add
_at the end of member name when it is duplicated with Python keyword (eg.mro).