Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Union tag docs now can be in parentheses #154

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Union tag docs now can be in parentheses #154

merged 1 commit into from
Jul 22, 2017

Conversation

dahlia
Copy link
Member

@dahlia dahlia commented Jul 22, 2017

Fixes #153.

Like record docs, union tag docs also now can be in parentheses e.g.:

union U
    = T1 ()
    # Docs after closing parenthesis still work.
    | T2 (
        # Docs after opening parenthesis now becomes supported. 🆕
    )
    ;

@dahlia dahlia added the typ:enhance Type: Enhancement/new feature label Jul 22, 2017
@dahlia dahlia self-assigned this Jul 22, 2017
@dahlia dahlia requested review from kanghyojun and AiOO July 22, 2017 16:05
kanghyojun
kanghyojun approved these changes Jul 22, 2017
View reviewed changes
examples/shapes.nrm
);

union shape
# Type constructors in a sum type become translated to subtypes in OO
# languages, and datatypes in functional languages.
= rectangle (point upper-left, point lower-right)
= rectangle (
# Each tag can have zero or more fields like record types.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dahlia dahlia merged commit 7853572 into nirum-lang:master Jul 22, 2017
@dahlia dahlia added the cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) label Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanghyojun kanghyojun kanghyojun approved these changes

@AiOO AiOO Awaiting requested review from AiOO

Assignees

@dahlia dahlia

Labels
cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) typ:enhance Type: Enhancement/new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dahlia @kanghyojun