Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service methods should be possible to specify its error type #127

Merged
merged 3 commits into from
Apr 20, 2017
Merged

Service methods should be possible to specify its error type #127

merged 3 commits into from
Apr 20, 2017

Conversation

kanghyojun
Copy link
Member

#38

dahlia
dahlia requested changes Mar 23, 2017
View reviewed changes
examples/pdf-service.nrm Outdated
@@ -1,3 +1,5 @@
@error("")
Copy link
Member

@dahlia dahlia Mar 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotations don't have to have arguments (including parentheses). Therefore we can simplify this as @error. See also the parser code.

@kanghyojun kanghyojun changed the title [WIP] Service methods should be possible to specify its error type Service methods should be possible to specify its error type Apr 1, 2017
@kanghyojun
Copy link
Member Author

kanghyojun commented Apr 1, 2017 •
edited
Loading

이제 남은 것은 Runtime쪽에서 __nirum_method_error_types__를 잡아서 에러로 반환하도록 하는 정도입니다 리뷰 부탁드려요 @dahlia

dahlia
dahlia requested changes Apr 1, 2017
View reviewed changes
Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@admire93 파일 중간에 패치 충돌한 흔적들이 보입니다.

@kanghyojun
Copy link
Member Author

@dahlia 리뷰를 부탁드립니다.

dahlia
dahlia requested changes Apr 20, 2017
View reviewed changes
src/Nirum/Targets/Python.hs Outdated
compileTypeDeclaration src
TypeDeclaration { typename = typename'
, type' = UnionType tags
, typeAnnotations = annotations } = do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

닫는 중괄호를 여는 중괄호에 맞춰서 들여쓰기 부탁합니다.

@kanghyojun kanghyojun merged commit 6b0223e into nirum-lang:master Apr 20, 2017
@kanghyojun kanghyojun self-assigned this Apr 20, 2017
@kanghyojun
Copy link
Member Author

nirum-lang/nirum-python#71 is folloing issue.

@dahlia dahlia added cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) cmp:runtime Component: Target runtimes cmp:transport Component: Transports labels Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlia dahlia dahlia approved these changes

Assignees

@kanghyojun kanghyojun

Labels
cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) cmp:runtime Component: Target runtimes cmp:transport Component: Transports
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanghyojun @dahlia