Add "minimum_runtime" option to Python target settings #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanghyojun
approved these changes
Mar 14, 2017
|
Though its build on macOS have been still failing (see also #115), as I tested it on my local macOS machine, I will merge this. |
dahlia
added
cat:packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
minimum_runtimeoption to Python target settings. The specified version goes to the generatedinstall_requireslist. Also the Nirum compiler now has its own minimum runtime version; see alsoNirum.Targets.Python.minimumRuntimeconstant.If
minimum_runtimeoption specified by package.toml is older than compiler's minimum runtime version, or it's omitted, compiler's version is used instead.Closes #118.