Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regressive things PR #111 missed #114

Merged
merged 3 commits into from
Mar 13, 2017
Merged

Fix regressive things PR #111 missed #114

merged 3 commits into from
Mar 13, 2017

Conversation

dahlia
Copy link
Member

@dahlia dahlia commented Mar 13, 2017

Fixed several things that PR #111 missed:

  • Remove cmdargs from build-depends as it's no more used since Use optparse-applicative instead of cmdargs #111 introduced optparse-applicative.
  • Update the CLI example on README.md as -t/--target became required.
  • Restore the list of available targets on -h/--help.

@dahlia dahlia added the typ:bug Type: Bug/defect label Mar 13, 2017
@dahlia dahlia self-assigned this Mar 13, 2017
@dahlia dahlia requested review from kanghyojun, yjroot and AiOO March 13, 2017 06:04
@dahlia dahlia merged commit 7efc37d into nirum-lang:master Mar 13, 2017
@dahlia dahlia added the cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) label Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanghyojun kanghyojun kanghyojun approved these changes

@yjroot yjroot Awaiting requested review from yjroot

@AiOO AiOO Awaiting requested review from AiOO

Assignees

@dahlia dahlia

Labels
cmp:frontend Component: Compiler frontend (e.g., CLI, parser, AST) typ:bug Type: Bug/defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dahlia @kanghyojun