fix connect and listenermixin combo (fixes #118) #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoike
added a commit
that referenced
this pull request
Nov 20, 2014
fix connect and listenermixin combo (fixes #118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code in connect dynamically imported the ListenerMixin methods, and threw an error if component already had prop with the same name that wasn't from ListenerMixin.
However, as React wraps all functions, the test to see if the methods were from ListenerMixin would always fail. This pull request therefore removes the test and replaces the error with a warning that you either clobbered your existing property, or used connect and ListenerMixin in the same object which is unnecessary.
This solves bug #118.