Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically bind store methods #100

Merged
merged 3 commits into from
Nov 20, 2014
Merged

Conversation

rymohr
Copy link
Contributor

@rymohr rymohr commented Oct 21, 2014

Bind store methods for consistent behavior with react components.

@spoike react requires an es5 shim if you want to support older browsers so I'm not sure there's a need to include a Function.prototype.bind polyfill:

http://facebook.github.io/react/docs/working-with-the-browser.html#browser-support-and-polyfills
https://github.com/facebook/react/blob/2bdad81955e160a5b11110b40c7222a1113cc1fb/src/browser/ui/React.js#L150

@rymohr rymohr mentioned this pull request Oct 21, 2014
@krawaller
Copy link
Contributor

Since Reflux is pretty useful without React I think it should be able to stand on its own legs regarding the shims, and not rely on React's es5 stuff.

@rymohr
Copy link
Contributor Author

rymohr commented Oct 21, 2014

I was curious if anyone was using it without react. I think facebook's policy of not including es5 shims is a good one in general, but it would be good to raise a warning and add a note to the readme in that case.

@spoike spoike added this to the 0.1.16 milestone Nov 20, 2014
spoike added a commit that referenced this pull request Nov 20, 2014
Automatically bind store methods
@spoike spoike merged commit 06e1140 into reflux:master Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants