Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix a bug with values.yaml not being loaded to the UI while migrating to SC4SNMP-UI #998

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

wojtekzyla
Copy link
Collaborator

@wojtekzyla wojtekzyla commented Apr 17, 2024

Description

fix a bug with values.yaml not being loaded to the UI while migrating to SC4SNMP-UI

Fixes # (issue)

Type of change

  • Bug fix

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@wojtekzyla wojtekzyla requested a review from ajasnosz April 17, 2024 14:37
Copy link
Collaborator

@ajasnosz ajasnosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update changes

@wojtekzyla wojtekzyla force-pushed the fix/load-values-yaml-to-ui branch from a09ccbd to d8b8398 Compare April 18, 2024 08:01
…ating to SC4SNMP-UI

fix: update wrong variable name

[run-ui-tests]

fix: update CHANGELOG

fix: update CHANGELOG
@wojtekzyla wojtekzyla force-pushed the fix/load-values-yaml-to-ui branch from d8b8398 to 3fe9e71 Compare April 18, 2024 13:55
@wojtekzyla wojtekzyla merged commit 3c9273b into develop Apr 19, 2024
11 of 12 checks passed
@wojtekzyla wojtekzyla deleted the fix/load-values-yaml-to-ui branch April 19, 2024 12:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 1.11.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants