raise_error + a block produces wrong failure message

[mcmire]

When using raise_error with a block and the block contains an assertion, the generated failure message includes the full error message of that assertion.

[pavolzbell]

Hello @mcmire, maybe I bumped into this one today, here is a sample output from our JRuby project running on:

• rspec-core 3.9.2
• rspec-rails 4.0.1
• super_diff 0.5.2

     Failure/Error: expect { subject.call(service, request) }.to raise(Java::JavaxXmlWsSoap::SOAPFaultException) { expect(1).to eq(0) }

       Expected raised exception #<RSpec::Expectations::ExpectationNotMetError "Expected \e[33m1\e[0m to eq \e[35m0\e[0m.">
                        to match #<Java::JavaxXmlWsSoap::SOAPFaultException>

Is there any chance for you to fix it? Can I help somehow?

Also wondering if this affects custom matchers which use nested expect calls inside match do |actual| ... end blocks...

[mcmire]

I think in this case you might need to use raise_error, not raise? Or can you use raise in JRuby like that, when you're writing an expectation?

[pavolzbell]

Oh, I'm sorry, of course it's raise_error, I just incorrectly copied the code, here is a short example you can run:

expect { raise 'x' }.to raise_error(RuntimeError) { |e| expect(e.message).to eq('x') } #=> true
expect { raise 'x' }.to raise_error(RuntimeError) { |e| expect(e.message).to eq('y') }
RSpec::Expectations::ExpectationNotMetError: Expected raised exception #<RSpec::Expectations::ExpectationNotMetError "Expected \e[33m\"x\"\e[0m to eq \e[35m\"y\"\e[0m.">
                 to match #<RuntimeError>

[mcmire]

Gotcha. 👍 Thanks for confirming this issue!

[mcmire]

Going back to the original issue, just ran into this again today. Here's a screenshot: