generated from spiral-packages/package-skeleton
-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of scopes #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #80 +/- ##
============================================
+ Coverage 99.14% 99.71% +0.56%
- Complexity 103 104 +1
============================================
Files 15 15
Lines 352 354 +2
============================================
+ Hits 349 353 +4
+ Misses 3 1 -2 ☔ View full report in Codecov by Sentry. |
butschster
approved these changes
Mar 20, 2024
roxblnfk
approved these changes
Mar 20, 2024
# Conflicts: # composer.json # src/Dispatcher.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a
temporal
scope to the dispatcher. Added opening of thetemporal.activity
scope when creating an activity. Now it is possible to define a scope for an activity and register dependencies in the container so that they are only available within thetemporal.activity
scope.For example, let's create an activity and specify the temporal.activity scope for it:
After that, we will define the binding of the activity within the temporal.activity scope:
As a result, the activity will receive dependencies that are defined within the temporal.activity scope.