-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): rework broadcast
plugin
#732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valery Piashchynski <[email protected]>
wolfy-j
approved these changes
Jun 17, 2021
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
==========================================
- Coverage 67.61% 67.57% -0.04%
==========================================
Files 93 94 +1
Lines 4817 4824 +7
==========================================
+ Hits 3257 3260 +3
- Misses 1146 1151 +5
+ Partials 414 413 -1
Continue to review full report at Codecov.
|
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
wolfy-j
approved these changes
Jun 18, 2021
- Rework internal message bus - Add new tests for the broadcast plugin and include them into the GA Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
wolfy-j
approved these changes
Jun 20, 2021
Signed-off-by: Valery Piashchynski <[email protected]>
This was referenced Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-plugin
Area: module
beta-nominated
Nominated for backporting to the RR in the beta channel.
C-enhancement
Category: enhancement. Meaning improvements of current module, transport, etc..
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
closes: #729
closes: #733
ref: #704
This PR introduces a reworked
broadcast
plugin, which is now more user friendly. In our previous approach,websockets
plugin was an implementation of thebroadcast
. Now, broadcast features excluded from thewebsockets
plugin and moved into a separatebroadcast
plugin which any plugin can import (in the plugin'sInit
func) to receive broadcast messages.Description of Changes
broadcast
which can be imported to any plugin to receivebroadcast
messages.Beta architecture:

Driver registration schema:
Configuration sample:
New proto schema (still in BETA):
LIMITATIONS
When you develop your own plugin, make sure to NOT duplicate Redis connections within 1 broadcast section:
For example, image you have such
broadcast
config:If you tried to push a message into the
test
andtest2
broadcast sections, the message will be duplicated, because you used the same Redis connection. This is equal to publish twice into thetest
ortest2
connections.You either should use 1 global Redis section OR local Redis sections connected to different clusters.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.