fix(orca): tying exceptions to tasks (#4517)

* fix(orca): tying exceptions to tasks * fix(orca): added test separately
spinnaker · Sep 1, 2023 · 27b697e · 27b697e
1 parent 73a1c6f
commit 27b697e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/orca-queue/src/main/kotlin/com/netflix/spinnaker/orca/q/handler/RunTaskHandler.kt b/orca-queue/src/main/kotlin/com/netflix/spinnaker/orca/q/handler/RunTaskHandler.kt
@@ -228,6 +228,8 @@ class RunTaskHandler(
                 }
                 val status = stage.failureStatus(default = TERMINAL)
                 stage.context["exception"] = exceptionDetails
+                //Adding here serves two purposes one to display taskwise failures,other to display the exact failure when continue pipeline is set to true
+                taskModel.taskExceptionDetails["exception"] = exceptionDetails
                 repository.storeStage(stage)
                 queue.push(CompleteTask(message, status, TERMINAL))
                 trackResult(stage, thisInvocationStartTimeMs, taskModel, status)

diff --git a/orca-queue/src/test/kotlin/com/netflix/spinnaker/orca/q/handler/RunTaskHandlerTest.kt b/orca-queue/src/test/kotlin/com/netflix/spinnaker/orca/q/handler/RunTaskHandlerTest.kt
@@ -583,6 +583,14 @@ object RunTaskHandlerTest : SubjectSpek<RunTaskHandler>({
               }
             )
           }
+
+          it("attaches the exception to the taskExceptionDetails") {
+            verify(repository).storeStage(
+              check {
+                assertThat(it.tasks[0].taskExceptionDetails["exception"]).isEqualTo(exceptionDetails)
+              }
+            )
+          }
         }
 
         and("the task should not fail the whole pipeline, only the branch") {