Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Add/Update SpineOpt Wizard #3005

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Update Add/Update SpineOpt Wizard #3005

merged 3 commits into from
Nov 8, 2024

Conversation

ptsavol
Copy link
Member

@ptsavol ptsavol commented Nov 8, 2024

This PR fixes some issues with the SpineOpt installer wizard that opens from the Add/Update SpineOpt button in Spine Toolbox's File->Settings->Tools menu.

Fixes #3002

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

@ptsavol ptsavol self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.15%. Comparing base (3599115) to head (d47ff3f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
spinetoolbox/widgets/add_up_spine_opt_wizard.py 93.87% 1 Missing and 2 partials ⚠️
spinetoolbox/widgets/settings_widget.py 0.00% 2 Missing ⚠️
spinetoolbox/helpers.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3005      +/-   ##
==========================================
+ Coverage   67.13%   67.15%   +0.02%     
==========================================
  Files         193      193              
  Lines       37102    37138      +36     
  Branches     4445     4450       +5     
==========================================
+ Hits        24909    24941      +32     
- Misses      10937    10939       +2     
- Partials     1256     1258       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptsavol ptsavol merged commit 9a5c21b into master Nov 8, 2024
18 checks passed
@ptsavol ptsavol deleted the issue_3002 branch November 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpineOpt Installation Wizard fails when Toolbox runs in a Conda environment on Windows
1 participant