Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening DB editor tab when editor window has a empty tab only #3003

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Nov 7, 2024

No associated issue

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.13%. Comparing base (554ef57) to head (d2275e9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
spinetoolbox/ui_main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
+ Coverage   67.12%   67.13%   +0.01%     
==========================================
  Files         193      193              
  Lines       37102    37102              
  Branches     4445     4445              
==========================================
+ Hits        24904    24910       +6     
- Misses      10932    10935       +3     
+ Partials     1266     1257       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 3599115 into master Nov 7, 2024
17 of 18 checks passed
@soininen soininen deleted the fix_open_db_editor_tab branch November 7, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant