Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Python 3.8 deprecation warning on Toolbox startup #2914

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Aug 7, 2024

At least we can tell users that we have warned them...

Re #2904

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 66.95%. Comparing base (5cb26c0) to head (3fcba39).

Files Patch % Lines
spinetoolbox/ui_main.py 61.11% 7 Missing ⚠️
spinetoolbox/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2914      +/-   ##
==========================================
- Coverage   66.96%   66.95%   -0.02%     
==========================================
  Files         189      189              
  Lines       36878    36887       +9     
  Branches     6312     6314       +2     
==========================================
+ Hits        24695    24696       +1     
- Misses      10871    10879       +8     
  Partials     1312     1312              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit ee9508f into master Aug 7, 2024
20 of 22 checks passed
@soininen soininen deleted the 2904_python_3.8_notification branch August 7, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant