Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict numpy<2 for bundled app #2853

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Restrict numpy<2 for bundled app #2853

merged 2 commits into from
Jun 19, 2024

Conversation

ptsavol
Copy link
Member

@ptsavol ptsavol commented Jun 19, 2024

Fixes an issue in bundle regarding missing numpy files. Happened with Spine-Toolbox-win-0.9.0.dev5+g64a369a5.zip

Re #2852

Checklist before merging

  • Unit tests pass

- This issue was caused by numpy 2.0 which was just released this week

Re #2852
@ptsavol ptsavol self-assigned this Jun 19, 2024
- It seems that PyInstaller 6.8.0 is not compatible with numpy 2.0+
- Removed hook-numpy.py because PyInstaller has it's own numpy hook with the same file name

Re #2852
@ptsavol ptsavol changed the title Include all of numpy in the bundle Restrict numpy<2 for bundled app Jun 19, 2024
@ptsavol ptsavol merged commit bb2fbae into master Jun 19, 2024
1 of 41 checks passed
@ptsavol ptsavol deleted the issue_2852 branch June 19, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant