Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowable Parameter Types #2176

Closed
DillonJ opened this issue Jun 22, 2023 · 4 comments
Closed

Allowable Parameter Types #2176

DillonJ opened this issue Jun 22, 2023 · 4 comments
Labels
Data enhancement Enhancement of existing feature
Milestone

Comments

@DillonJ
Copy link
Contributor

DillonJ commented Jun 22, 2023

This functionality was planned at some stage and I just wanted to check if it's in the plan.

A major issue in SpineOpt is that some parameters need to be a specific type. However, we have no current way to enforce this in toolbox. Duration parameters like minimum_up_time are an example. Time and again, users get caught out by either entering a scalar value for these parameters or typing in a duration value like "1h" that gets stored as a string rather than a duration. The user will then get an error in SpineOpt and the cause is not easily identified for a new user.

Toolbox supports timeseries, time pattern, scalar and map parameters but in the parameter definiition we need to be able to enforce a specific subset of these for individual parameters.

I have a couple of questions:

  1. Does the new data structure allow for this?
  2. Is it in the implementation plan?

@jkiviluo @manuelma ?

@DillonJ DillonJ added enhancement Enhancement of existing feature Data labels Jun 22, 2023
@jkiviluo
Copy link
Member

The new data structure will allow this, but this part has not yet been implemented. So, it's in the plan, which is not written out clearly anywhere as far as I remember - we should do that. Meanwhile, there is this diagram: https://drive.google.com/file/d/1Ujd17uTIdn_chPdYNhLa6xWQCC_wPKtQ/view?usp=sharing

@DillonJ
Copy link
Contributor Author

DillonJ commented Jun 22, 2023

Thanks @jkiviluo that's what I thought... I was just surprised there wasn't already an issue on this, but we have it now

@jkiviluo jkiviluo added this to the V0.8 milestone Aug 10, 2023
@DillonJ
Copy link
Contributor Author

DillonJ commented Mar 13, 2024

This would have prevented this issue: spine-tools/SpineOpt.jl#937 and a lot of issues like it.

I think it would be a very valuable functionality that we've needed for a long time. I see it's tagged wit the V0.8 milestone. It would be nice if it could get done somehow

@jkiviluo
Copy link
Member

jkiviluo commented Nov 5, 2024

This has been implemented, although there could be more functionality to define parameter types inside maps (but that should be another issue).

@jkiviluo jkiviluo closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data enhancement Enhancement of existing feature
Projects
None yet
Development

No branches or pull requests

3 participants