Skip to content

Commit

Permalink
Restrict numpy<2 for bundled app (#2853)
Browse files Browse the repository at this point in the history
- It seems that PyInstaller 6.8.0 is not compatible with numpy 2.0+

Re #2852
  • Loading branch information
ptsavol authored Jun 19, 2024
1 parent 64a369a commit bb2fbae
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/make_bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,17 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install "numpy<2" # See issue #2852. Remove when PyInstaller supports numpy 2.0+
python -m pip install -r requirements.txt
- name: Run tests
run: |
python -m unittest discover --verbose
- name: Install PyInstaller
run: |
python -m pip install PyInstaller
- name: List packages
run:
python -m pip list
- name: Download embeddable Python
run: |
mkdir embedded-python
Expand Down
1 change: 0 additions & 1 deletion PyInstaller hooks/hook-jupyter_client.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from PyInstaller.utils.hooks import collect_all


datas, binaries, hiddenimports = collect_all("jupyter_client")
1 change: 0 additions & 1 deletion PyInstaller hooks/hook-qtconsole.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from PyInstaller.utils.hooks import collect_all


datas, binaries, hiddenimports = collect_all("qtconsole")

0 comments on commit bb2fbae

Please sign in to comment.