Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MintX509Svid should support svid_hints #5445

Open
stevend-uber opened this issue Aug 30, 2024 · 5 comments
Open

MintX509Svid should support svid_hints #5445

stevend-uber opened this issue Aug 30, 2024 · 5 comments
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@stevend-uber
Copy link
Contributor

The Mintx509SVID API should accept hints as a field when minting a new x509. This would allow parity with the normal operations of creating a new entry for deployments of SPIRE.

https://github.com/spiffe/spire-api-sdk/blob/main/proto/spire/api/server/svid/v1/svid.pb.go#L24

@MarcosDY MarcosDY added priority/backlog Issue is approved and in the backlog help wanted Issues with this label are ready to start work but are in need of someone to do it labels Sep 3, 2024
@amartinezfayo
Copy link
Member

For consistency, we should add this in the MintJWTSVIDRequest message also.

@SpectralHiss
Copy link

This seems like a straightforward task, I will take a stab at it today as a first contribution if nobody is already working on it

@SpectralHiss
Copy link

Actually although it is just a case of adding a field and returning it, it got me thinking what is the point? If an admin operator is minting a one off cert or token, wouldn't they already know the purpose of the SVID? curious about the initial use-case @stevend-uber

@stevend-uber
Copy link
Contributor Author

@SpectralHiss in a highly dynamic environment where minting SVIDs happens in addition to normal certificates, svid-hints help with provenance and metrics. At Uber, these are additionally minted through automation in addition to admin operator minting.

@azdagron
Copy link
Member

I think what @SpectralHiss is getting at is that the hint is normally conveyed back alongside the SVID on the workload API, not as a property of the SVID. In other words, where would you expect the hint provided to this API to end up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

No branches or pull requests

5 participants