Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mini-rx-store): fix wrong deprecation warning #227

Merged

Conversation

spierala
Copy link
Owner

@spierala spierala commented Dec 17, 2024

createFeatureStateSelector has the implementation.

Deprecated createFeatureSelector uses createFeatureStateSelector.

@carlos-ds
Copy link
Collaborator

Nice approach, although you'll have to adjust the deprecated method as well if createFeatureStateSelector changes. But it's probably not very prone to change so a very minor issue.

@spierala spierala merged commit 861a925 into release-2024.1 Dec 19, 2024
@spierala spierala deleted the 217-createFeatureStateSelector-deprecation-warning branch December 19, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mini-rx-store: wrong deprecation warning for createFeatureStateSelector
3 participants