-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support user snippets in repositories #784
base: main
Are you sure you want to change the base?
Conversation
We have already discussed it on discord and I already said no to it. This is not something that should be implemented at EOL of v2 basically and it doesn't bring anything good. No one will use it regardless. I'm against of merging this pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea. It would mean people can add their own snippets without needing to submit a PR and have someone from the team take the time to review it. Snippets are very safe compared to extensions, which we allow without manual review.
What if we make it so it shows the built-in snippets from the repo but also adds support for user snippets? Otherwise we'd lose the ones we have unless we put them somewhere else. |
Isnt this PR already implementing this, or are you talking abt v3? I don't know if we/the team wants user snippets in v3 because it would kinda disrupt the whole monomanifest flow, no? To bypass the loss of the current snippets couldn't you just add them to the official modules repo then? Or would that also mean having to filter good/bad snippets for the official repo? |
Ohh, my bad, I didn't read it through fully, I was thinking it just changed snippets to be user-based, which I think is what I had originally done. |
I think this all looks great! One thing is that we'd have to add support for authors just to ensure people are credited, additionally all the hrefs currently lead to the marketplace repo, we'd have to connect them to the correct repo. @zhngharry |
Based on #435
Implements the functionality that user hosted snippets in own repositories are fetched and shown in marketplace.
Important notes/alternatives considered:
Sidenote: PR #781 fixes the issue that users aren't able to host different types of creations within the same repo