-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intersphinx: Don't warn about pure-duplicate ambiguous definitions when loading 'objects.inv' entries. #12586
Merged
AA-Turner
merged 4 commits into
sphinx-doc:master
from
jayaddison:issue-12585/objectsinv-ambiguity-false-positive-reduction
Jul 15, 2024
Merged
intersphinx: Don't warn about pure-duplicate ambiguous definitions when loading 'objects.inv' entries. #12586
AA-Turner
merged 4 commits into
sphinx-doc:master
from
jayaddison:issue-12585/objectsinv-ambiguity-false-positive-reduction
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…report/false-positive case sphinx-doc#12585
…finitions in `objects.inv` entries.
jayaddison
changed the title
Issue 12585/objectsinv ambiguity false positive reduction
intersphinx ambiguities: don't warn about pure-duplicate ambiguous definitions in 'objects.inv' entries.
Jul 15, 2024
jayaddison
changed the title
intersphinx ambiguities: don't warn about pure-duplicate ambiguous definitions in 'objects.inv' entries.
intersphinx: Don't warn about pure-duplicate ambiguous definitions when loading 'objects.inv' entries.
Jul 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
…ion (and add corresponding type-hint).
AA-Turner
reviewed
Jul 15, 2024
Oh, this should have had a CHANGES entry... A |
jayaddison
deleted the
issue-12585/objectsinv-ambiguity-false-positive-reduction
branch
July 15, 2024 17:43
"Reduce log severity of detected ambiguous Intersphinx inventory items that are found to be case-insensitive duplicates." ? |
(rationale: they are still resolved ambiguously, but since they're duplicates, they're basically innocuous) |
AA-Turner
added a commit
that referenced
this pull request
Jul 15, 2024
Added a variant of that as 12064e0. A |
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
objects.inv
entries resolve to exactly the same result (i.e. are duplicates that differ only by lowercase/uppercase characters).Detail
Useset
-comparison of the reference fields.debug
message for reference.Todo / open questions
Relates
Edit: clarify the false-positive warning that is filtered by this branch.