Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in new language warning #10491

Closed
pquentin opened this issue May 30, 2022 · 4 comments · Fixed by #10492
Closed

Typo in new language warning #10491

pquentin opened this issue May 30, 2022 · 4 comments · Fixed by #10492
Labels

Comments

@pquentin
Copy link

pquentin commented May 30, 2022

Describe the bug

See the following snippet:

sphinx/sphinx/config.py

Lines 167 to 174 in e1bf4dd

# Note: Old sphinx projects have been configured as "langugae = None" because
# sphinx-quickstart previously generated this by default.
# To keep compatibility, they should be fallback to 'en' for a while
# (This conversion should not be removed before 2025-01-01).
if namespace.get("language", ...) is None:
logger.warning(__("Invalid configuration value found: 'language = None'. "
"Update your configuration to a valid langauge code. "
"Falling back to 'en' (English)."))

Both langugae and langauge are used incorrectly.

How to Reproduce

Noticed in Read the Docs: https://readthedocs.org/projects/trustme/builds/17039627/

Expected behavior

Mention "language" without typos.

Your project

https://github.com/python-trio/trustme/tree/master/docs

@AA-Turner
Copy link
Member

Fix is in #10492 - this is just a cosmetic issue as the actual code spells "language" correctly.

A

@pquentin
Copy link
Author

Definitely cosmetic, yes, but that warning is highly visible. Thanks for the fix!

@oleksiyskononenko
Copy link

What about all the sphinx.po files for different locales? They all still have the typo, for instance, https://github.com/sphinx-doc/sphinx/blob/5.x/sphinx/locale/ar/LC_MESSAGES/sphinx.po#L178

Are these files autogenerated based on config.py somehow? If not, should they all be fixed too?

@AA-Turner
Copy link
Member

Every Sunday. (https://github.com/sphinx-doc/sphinx/actions/workflows/transifex.yml)

A

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants