From 65ff8c07a9e5e5ffe12c0bd9fdb6f7f3c2266a68 Mon Sep 17 00:00:00 2001 From: "Albert Y. Shih" Date: Tue, 8 Aug 2023 09:03:05 -0400 Subject: [PATCH] Flip the logical branching --- sphinx/ext/inheritance_diagram.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sphinx/ext/inheritance_diagram.py b/sphinx/ext/inheritance_diagram.py index 100c2e697e0..ca9acf3c5b1 100644 --- a/sphinx/ext/inheritance_diagram.py +++ b/sphinx/ext/inheritance_diagram.py @@ -413,10 +413,10 @@ def html_visit_inheritance_diagram(self: HTML5Translator, node: inheritance_diag for child in pending_xrefs: if child.get('refuri') is not None: # Construct the name from the URI if the reference is external via intersphinx - if child.get('internal', True): - refname = child['reftitle'] - else: + if not child.get('internal', True): refname = child['refuri'].rsplit('#', 1)[-1] + else: + refname = child['reftitle'] urls[refname] = child.get('refuri') elif child.get('refid') is not None: