-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checker for searching unnecessary parentheses in func & meth role #115
Add checker for searching unnecessary parentheses in func & meth role #115
Conversation
77a1cfe
to
23f1f9b
Compare
23f1f9b
to
ad11bdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The failures are expected, because we're running the linter on some "friend projects" which fail this new rule.
How should we handle these? We can send PRs to the projects in question, but should we mark them as xfail here, or temporarily exclude the new rule from the relevant projects here?
Co-authored-by: Hugo van Kemenade <[email protected]>
47b2fa5
to
ec6262e
Compare
I've disabled the checker. Let me send PRs to those 4 friend projects, and I'll enable it once those patches are merged. |
Send another commit for checking the meth role, as suggested by @AA-Turner (ref). |
cb3a7df
to
0754dc2
Compare
Issues from the friend projects are all resolved. The checker is enabled now and should be able to pass CI. |
Thanks! |
Thank you! |
I'll make a new release, we've since introduced a new "friend project" failure into CPython because Sphinx Lint didn't catch it 😅 |
resolve #114
test summary