Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change port with python SpheroRvrObserver #12

Open
cletusw opened this issue Oct 3, 2020 · 2 comments
Open

Can't change port with python SpheroRvrObserver #12

cletusw opened this issue Oct 3, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@cletusw
Copy link

cletusw commented Oct 3, 2020

With the asyncio code I can properly set the port the Pi should use to communicate with the RVR (my Pi is set up as a USB Serial Gadget).

rvr = SpheroRvrAsync(
    dal=SerialAsyncDal(
        loop,
        port_id = "/dev/ttyGS0"
    )
)

SpheroRvrObserver, however, does not accept a dal parameter and so changing the port is not possible. Could this be added as an option?

@Jim-Konish
Copy link
Contributor

Hi @cletusw, this is a good suggestion, and may go into a future update to the SDK. In the meantime, you can edit the port in sphero_sdk/observer/client/dal/serial_observer_dal.py. This will work, though I realize it's not ideal.

@Jim-Konish Jim-Konish added the enhancement New feature or request label Nov 14, 2022
@cletusw
Copy link
Author

cletusw commented Nov 14, 2022

Thanks! Glad to hear it's being considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants