Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested classes report UnknownNamespace.UnknownMethod #41

Merged
merged 2 commits into from
Sep 17, 2023

Conversation

pageyboy
Copy link
Contributor

@pageyboy pageyboy commented Sep 5, 2023

Fixes https://github.com/spekt/xunit.testlogger/issues/48

Updated regex to handle nested class scenario as classes use + as a separator
Added test case

Updated regex to handle nested class scenario as classes use + as a
separator
Added test case
@codito
Copy link
Contributor

codito commented Sep 7, 2023

@pageyboy fix looks good to me. Can we check why the acceptance tests are failing?

EDIT: fixed a test flakiness in 6eb1221, let's see if that fixes the PR build.

@pageyboy
Copy link
Contributor Author

Hi @codito,
Sorry for the delay, I've merged those changes in and all looks good on my end

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6eb1221) 100.00% compared to head (60da981) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          739       739           
=========================================
  Hits           739       739           
Files Changed Coverage Δ
src/TestLogger/Core/TestCaseNameParser.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codito codito merged commit c26414c into spekt:master Sep 17, 2023
4 checks passed
@codito
Copy link
Contributor

codito commented Sep 17, 2023

Thanks @pageyboy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested classes cause UnknownNamespace.UnknownType to be outputted
2 participants