Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spek should be compatible with JUnit Platform suites #986

Open
marcphilipp opened this issue Oct 29, 2021 · 1 comment
Open

Spek should be compatible with JUnit Platform suites #986

marcphilipp opened this issue Oct 29, 2021 · 1 comment
Labels
status: triage

Comments

@marcphilipp
Copy link
Contributor

JUnit 5.8 introduced @Suite classes and a new engine to execute them. Spek is currently incompatible with them because it does not use the UniqueId passed in to TestEngine.discover for the children of the engine descriptor and instead constructs its own:
https://github.com/spekframework/spek/blob/2.x/spek-runner-junit5/src/main/kotlin/org/spekframework/spek2/junit/SpekTestDescriptor.kt#L20
@rpalcolea
Copy link

Hi @raniejade

Having proper UniqueId support would help people using Gradle to use features such as test retries, predictive test selection and test distribution

Wondering if you have any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcphilipp @rpalcolea