Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be possible to condition the build-only PackageReferences? #1421

Closed
baronfel opened this issue Jan 2, 2024 · 1 comment · Fixed by #1425
Closed

Would it be possible to condition the build-only PackageReferences? #1421

baronfel opened this issue Jan 2, 2024 · 1 comment · Fixed by #1425

Comments

@baronfel
Copy link
Contributor

baronfel commented Jan 2, 2024

Hi! I am trying to get Spectre.Console added to the dotnet/source-build-externals repo so that the SDK and MSBuild can take references to it in ways that work with our Linux Source Build partners' support lifecycles. As a part of that, I have a patch that comments out a number of build-metadata-related packages, but patches like this are fragile. Would you all be amenable to a solution where a property is checked in a Condition on this ItemGroup, and then the source-build-externals build of Spectre.Console could pass that property? If so, I'd be happy to contribute that.

@patriksvensson
Copy link
Contributor

@baronfel Sure, sounds reasonble to me. We will happily accept a patch for this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
2 participants