Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency w/ "No preparations" for COs that have a prep with an empty count #6158

Open
combs-a opened this issue Jan 24, 2025 · 0 comments
Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more

Comments

@combs-a
Copy link
Collaborator

combs-a commented Jan 24, 2025

Describe the bug
When there is a Collection Object that has a Preparation that doesn't have a count and there is another without any preparations at all, the first CO does not show in the list of COs without preps.

If you just have it by itself, then the dialog for no preparations comes up when you click next.

If you have it with a CO that does have preparations, it goes to the preparation selection dialog. The empty preparation is not there (which is expected).

To Reproduce
Steps to reproduce the behavior:

Might be easier if on sdnhm_herps_2_8_24 since there's already COs that match the description.

  1. Go to Loans
  2. Select "By entering Catalog numbers"
  3. Add COs that have a preparation without a count (666666 on sdnhm), COs that don't have preparations (777777), and COs that do have a preparation with a count (123456) and click next.
  4. See that only the CO without any preparations appears in the list of preps without preparations.
  5. Remove the CO that doesn't have preparations and click next.
  6. See that there's no warning about no preparations on CO with prep without a count.
  7. Remove the CO that does have preparations with a count and click next.
  8. See that the "Without preparations" dialog comes up.

Expected behavior
Not the worst behavior but it is inconsistent. A CO that has the "Continue without preparations" dialog come up when it's by itself should be in the list of COs that don't have preparations when there's multiple.

Screenshots

Screenshot of the list; 666666 should be in this list.
Image

Screenshot of having a preparation with no preps.
Image

Crash Report

Please fill out the following information manually:

  • OS: Windows 10
  • Browser: Firefox
  • Specify 7 Version: v7.9.11, v7.9.6.2
  • Database Name: sdnhm_herps_2_8_24
  • Collection name: Herp-PC
  • User Name: testuser

Additional context

URL to 666666: https://sdnhmherps2824-production.test.specifysystems.org/specify/view/collectionobject/80740/

@combs-a combs-a added 1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more
Projects
None yet
Development

No branches or pull requests

1 participant