Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exported queries with # or ? in name are not downloadable #5069

Open
melton-jason opened this issue Jul 4, 2024 · 1 comment · May be fixed by #5070
Open

Exported queries with # or ? in name are not downloadable #5069

melton-jason opened this issue Jul 4, 2024 · 1 comment · May be fixed by #5070
Assignees
@melton-jason
Labels
1 - Bug Incorrect behavior of the product 2 - Queries Issues that are related to the query builder or queries in general

Comments

@melton-jason
Copy link
Contributor

To Reproduce
Steps to reproduce the behavior:

  1. Save a query which contains a # or ? in the name
  2. Export the query as a CSV or KML
  3. When the notification is sent to the user, attempt to download the resulting file
  4. See error

Expected behavior
The query should be downloadable even if it contains special characters in the name

Screenshots

https://kufish51623-edge-2.test.specifysystems.org/specify/query/194/

Screen.Recording.2024-07-03.at.7.30.27.PM.mov

Please, also fill out the following information manually:

  • OS: macOS Sonoma 14.3
  • Browser: Chrome
  • Specify 7 Version: edge (7.9.6 - 080b32c)
  • Database Name: KUFish_5_16_23
  • Collection name: KU Fish Voucher Collection
  • User Name: spfishadmin

Reported By
Diana @ University of Kansas Mammals Collection
@melton-jason melton-jason added 1 - Bug Incorrect behavior of the product 2 - Queries Issues that are related to the query builder or queries in general labels Jul 4, 2024
@melton-jason melton-jason self-assigned this Jul 4, 2024
melton-jason added a commit that referenced this issue Jul 4, 2024
@melton-jason
Properly encode file names for download links
23679b7 
Fixes #5069
@melton-jason melton-jason linked a pull request Jul 4, 2024 that will close this issue
Open
5 tasks
@emenslin
Copy link
Collaborator

Can recreate in edge (7.9.6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melton-jason melton-jason

Labels
1 - Bug Incorrect behavior of the product 2 - Queries Issues that are related to the query builder or queries in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Encode exported Query file paths specify/specify7
2 participants
@melton-jason @emenslin