Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA specs broken - definitionMap not defined #2848

Open
1 task done
jnurthen opened this issue Apr 17, 2020 · 3 comments
Open
1 task done

ARIA specs broken - definitionMap not defined #2848

jnurthen opened this issue Apr 17, 2020 · 3 comments
Labels
bug legacy For supporting legacy profiles

Comments

@jnurthen
Copy link
Contributor

Important info

Description of problem

ARIA (and a number of specs) have shared terms. We clean these up by removing any which are not referenced in https://github.com/w3c/aria-common/blob/master/script/resolveReferences.js which includes the following where it attempts to remove references from respec

                $p.getDfnTitles().forEach(function( item ) {
                    if (respecConfig.definitionMap[item]) {
                        delete respecConfig.definitionMap[item];
                    }
                });

This no longer works

This worked when we published in December so my guess is that this is caused by https://github.com/w3c/respec/pull/2682

Can you help us get this working again. I don't mind making minor code changes to get it working.

@jnurthen
Copy link
Contributor Author

w3c/aria-common#98

@sidvishnoi sidvishnoi added legacy For supporting legacy profiles bug labels Apr 17, 2020
@sidvishnoi
Copy link
Member

sidvishnoi commented Apr 17, 2020

That's indeed a regression. We recently stopped supporting the w3c-common profile, but I'll get the fix for this bug in.

Alternatively, if you could explain what exactly resolveReferences.js does, we might be able to integrate it in ReSpec. I've seen similar thing being used in json-ld specs if I'm not wrong.

@saschanaz I'm thinking of creating a side-channel for updates to w3c-common profile. We won't actively support it, but may add fixes for severe regressions. My plan is to branch off v25.5.0, build manually when needed (should be rare) and copy builds to /builds folder when we release.

The bug here is, we copied over definitionMap instead of referencing it in to respecConfig. Also, definitionMap as key in respecConfig got lost.
https://github.com/w3c/respec/blob/45a4d300c3bbe30f2a81d7b9a978d837a3494458/src/w3c/defaults.js#L55

@saschanaz
Copy link
Collaborator

Sounds good, we should still maintain it even when we don't add features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug legacy For supporting legacy profiles
Projects
None yet
Development

No branches or pull requests

3 participants