-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Encoding Standard #1537
Comments
Hmmmm, nothing broke when I tested the changes yesterday, which is interesting. I'll look into this shortly. |
Dupe of #1536. It is certainly bikeshed BTW because this happened after I did bikeshed update to reproduce the build failure in my spec. There was a suggested culprit there, can we look to see if reverting that fixes the problems? This seems to affect a lot of specs. |
Yup, dupe. |
Still broken: https://travis-ci.org/whatwg/encoding/builds/595542510. Is that because the API version of Bikeshed still needs updating or because there's a more unique issue? |
(Re-closing because this is still a dupe.) |
TextDecoderCommon defines
encoding
twice, once as dfn and once as attribute. This used to work fine as you can see at https://encoding.spec.whatwg.org/#textdecoder-encoding (dfn) and https://encoding.spec.whatwg.org/#dom-textdecoder-encoding (attribute). It now fails on master https://travis-ci.org/whatwg/encoding/builds/595542510 withInterestingly enough, this still worked yesterday as the PR I created for this did not report this error, which strongly suggests Bikeshed is the culprit here.
The text was updated successfully, but these errors were encountered: