*: Fix missing space between (c) and <alt> #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @zvr about fixing his pretty-printer before we get more of these ;). |
|
some of these have already been fixed and seems to be viewing okay as per Preview check |
|
On Thu, Dec 28, 2017 at 11:16:56PM +0000, Jilayne Lovejoy wrote:
some of these have already been fixed and seems to be viewing okay as per Preview check
https://spdx.org/licenses/preview/GPL-1.0 doesn't even render in preview:
XML Parsing Error: mismatched tag. Expected: </br>.
Location: https://spdx.org/licenses/preview/GPL-1.0
Line Number 176, Column 9: </p>
--------^
Looks like an unclosed <br>.
|
|
Ah, I was missing the .html. Looking at that:
$ curl -s https://spdx.org/licenses/preview/GPL-1.0.html | grep -B1 '<var.*19xx'
Copyright (C)
<var class="replacable-license-text">19xx name of author</var>
the tool seems to be injecting a newline before the <var> (which fixes
this case, but introduces an unwanted space in other places. For
example:
$ curl -s https://spdx.org/licenses/preview/CC-BY-4.0.html | grep -B1 'wiki.creativecommons.org/Considerations_for_licensees'
<var class="replacable-license-text">More considerations</var> for the public
<var class="replacable-license-text">: wiki.creativecommons.org/Considerations_for_licensees</var></p>
should not have whitespace before the colon.
|
Generated with: $ sed -i 's/\(([cC])\)<alt/\1 <alt/' $(git grep -l '[cC])<alt') Like 7af2b40 (BSD-1-Clause: Add a space between "(c)" and "<year>", 2017-12-19, spdx#526), but with more licenses. The ones I'm fixing here were mostly broken by a0879e6 (reformatted (pretty-printed) the 10 GNU licenses, 2017-12-23, spdx#553).
wking
force-pushed
the
copyright-alt-space
branch
from
62ad7e2 to
5d907de
Compare
goneall
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with:
Like 7af2b40 (#526), but with more licenses. The ones I'm fixing here were mostly broken by a0879e6 (#553).