Implement Key Generation Command for Enhanced Security #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahNxT
changed the title
|
Nice! Could you also add tests for that command? De tests on Laravel 9 are failing. Feel free to drop support for that Laravel version. |
|
I'll add some tests and drop the support of L9 later today. |
|
@freekmurze Added some tests, been struggling a bit with the usage of a .env in the test suite. If you have any comments, let me know! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I'm replicating the feature set of https://github.com/tymondesigns/jwt-auth, which enables users to generate their key/secret using a command. This addition encourages the adoption of more secure keys, in line with industry best practices for security. Additionally, users still retain the option to use a self-chosen key if desired.