Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert static methods to scopes #396

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

gdebrauwer
Copy link
Contributor

Converting the whereLocale() / whereLocales() static methods to scopes makes it possible to use them on existing queries instead of being required to use them as the first method

@freekmurze
Copy link
Member

freekmurze commented Jun 20, 2023

I like the proposal, but this is a breaking change. Could you re-add the old methods and add a @deprecated annotation above the function? We'll remove these old methods in the next major version of the package.

@freekmurze freekmurze merged commit 29d08d2 into spatie:main Jun 20, 2023
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants