Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create "conversions" directory when there are no conversions #48

Closed
vedmant opened this issue Aug 19, 2015 · 1 comment
Closed

Don't create "conversions" directory when there are no conversions #48

vedmant opened this issue Aug 19, 2015 · 1 comment

Comments

@vedmant
Copy link

vedmant commented Aug 19, 2015

Hi, I think it will be better not to create "conversions" directory when there are no conversions for model, in some cases it creates many empty directories. For example when it's not images uploaded, but documents or videos, or even images but with no conversions. Also makeDirectory($directory.'/conversions'); (or check if it exists) can be moved to performConversions function and launched only if there are any conversions.

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@freekmurze @vedmant