Bug: getUrl('conversion_name') always returns .jpg when using ->keepOriginalImageFormat()

[mauricekindermann]

When using keepOriginalImageFormat() on a conversion, while the conversion itself correctly generates files with the original extension (e.g., .png), the URLs generated by getUrl() still use .jpg extension.

The cause seems to be part of the Conversion constructor - it sets a default format('jpg') manipulation which isn't removed when keepOriginalImageFormat() is called.

I cannot PR this, but I suspect the fix is something like this

class Conversion
{ 
  public function keepOriginalImageFormat(): self
  {
      $this->keepOriginalImageFormat = true;
      $this->removeManipulation('format');  // Add this line
      return $this;
  }
}

[mauricekindermann]

For now I am doing this since I have a mix of imported media with original file extensions, and the default jpg conversions (which is a big "gotcha" in this library). And I have 500k files/conversions so it's not trivial to fix this in production.

class Media extends BaseMedia
{
  public function getCorrectUrl(string $conversionName = ''): string
      {
          if ($conversionName === '') {
              return $this->getUrl();
          }
      
          $url = $this->getUrl($conversionName);
          $path = $this->getPath($conversionName);
      
          // If jpg conversion doesn't exist
          if (!file_exists($path)) {
              $originalExt = pathinfo($this->file_name, PATHINFO_EXTENSION);
              $originalPath = str_replace('.jpg', '.'.$originalExt, $path);
              
              // Check if original extension version exists
              if (file_exists($originalPath)) {
                  return str_replace('.jpg', '.'.$originalExt, $url);
              }
              
              // If neither exists, return original file URL
              return $this->getUrl();
          }
      
          return $url;
      }
}

[freekmurze]

I'd be happy to merge in a PR that fixes this + added tests 👍

[mauricekindermann]

I will see what I can do, will take me a few weeks at best.