fix: Node.new second argument is typechecked #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It must be a Node, it should be a Document (and a warning will be emitted if it is not). Closes #975
flavorjones
force-pushed
the
975-type-check-node-new-param
branch
from
719855c to
3a56272
Compare
javierjulio
added a commit
to jackpocket/worldpay-cnp
that referenced
this pull request
Jan 27, 2022
This fixes the following deprecation warning: ``` worldpay_cnp-0.1.0/lib/worldpay_cnp/xml/nokogiri.rb:36: warning: Passing a Node as the second parameter to Node.new is deprecated. Please pass a Document instead, or prefer an alternative constructor like Node#add_child. This will become an error in a future release of Nokogiri. ``` We are now passing the document along with the parent element. The serializer will handle the case of setting the parent to the document, when the parent is nil due to the recursive nature of the method calls. This deprecation was included in release 1.13.0 https://github.com/sparklemotion/nokogiri/releases/tag/v1.13.0 For reference: sparklemotion/nokogiri#975 and sparklemotion/nokogiri#2401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
The second argument to Node.new must be a Node, and it should be a Document (and a warning will be emitted if it is not).
Closes #975
Have you included adequate test coverage?
Yarp
Does this change affect the behavior of either the C or the Java implementations?
Both implementations have been updated.