Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Fix #391 #1373

Closed
wants to merge 1 commit into from
Closed

[RFC] Fix #391 #1373

wants to merge 1 commit into from

Conversation

ylecuyer
Copy link
Contributor

This PR fixes #391

@ylecuyer ylecuyer changed the title Add failing test to get #391 fixed [RFC] Fix #391 Nov 15, 2015
@flavorjones
Copy link
Member

Hi, @ylecuyer. Thanks so much for the PR!

The test looks reasonable to me, but this change was only made to the C extension, which is now causing JRuby failures. Were you planning on tackling the Java extension, or would you like someone else to look into it?

@ylecuyer
Copy link
Contributor Author

@flavorjones the failure is only due to the test case, it would be nice if someone could help me to improve the test. Currently I'm just comparing the two xml but jruby seems to order the xml nodes in a different way.

@flavorjones
Copy link
Member

Ah, please ignore my comment above -- this bug doesn't exist on JRuby, and therefore no need to fix it there. :-\

@flavorjones
Copy link
Member

I've replaced the test in this PR with the test case provided at #391, which avoids the JRuby document output issue in this test. Also cleaned it up a bit, but your name is still on it as author.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform/jruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nokogiri adds 'default' Namespace to elements
2 participants
@ylecuyer @flavorjones