fix over-eager namespace pruning when reparenting nodes

[ccutrer]

fixes #1332

[sgringwe]

I would love to see this pull request merged as it affects us too, any update on this?

[sgringwe]

@larskanis is there any update on this? we are still locked into @ccutrer 's version and would love to of course be able to get updates from newer versions

[larskanis]

This PR sounds reasonable to me. It doesn't fully align JRuby and MRI implementations, but brings it closer together.

@flavorjones Could you please have a look at this?

[bradleybeddoes]

@larskanis @flavorjones any chance of this making it into 1.6.8? I'm also getting tripped up on this one.

[flavorjones]

Yes, plan is to include in 1.6.8 final. Spent tonight going through old issues, will spend my next hack night finishing 1.6.8. Thanks for your patience.

[flavorjones]

Apologies to just getting to this now -- the second test passes on master, can you help me understand why it's there?

Also, there are two conditionals being added to the ns check (both are NULL, or both are equal) and I'd like to make sure they're both being tested.

[bradleybeddoes]

What is the process here for assisting on a PR proposed by someone else?.

I am happy to try and assist resolve these questions but I don't want to impact/take any credit for the good work already done by @ccutrer.

[bradleybeddoes]

Further to the above comment if it is helpful in any way I've proposed #1444

[bradleybeddoes]

@flavorjones did you have any further thoughts on this PR or #1444 ?

Apologies for being a pest about this, it is just a really important fix for a new project I need to ship asap.

[flavorjones]

I merged one of these tests and the fix into master manually and given you credit in the commit log.

I apologize I couldn't find a better way to keep your name on the commits.

Thank you so much!