-
-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JRuby unable to create HTML doc if URL arg provided #674
Comments
I'm confirming that this is still an issue in 1.5.3. |
Reproduced using this script:
output for me:
@yokolet - any ideas? |
The problem is that the url is assumed to be a local file path. I modified the code to use the [URI.create](http://docs.oracle.com/javase/6/docs/api/java/net/URI.html#create(java.lang.String\)) method to parse the url and fall back to the old behavior in case of failure. |
@jvshahid's patch looks ok. But, before merging the change, let me clarify this. @flavorjones I still don't understans "nonet" option should prevent what. |
OK. I figured out Nokogiri is allowed to connect the Internet in this case with nonet option. @jvshahid would you give us pull request for this fix as well? The test case needs a bit tweak when there's not internet connection available. I'll do that after merging pull request. |
I created a pull request here |
I merged the pull request. Thanks! |
in 1.5.5.rc1 |
If a URL is provided when creating a document, Nokogiri errors out on JRuby:
The text was updated successfully, but these errors were encountered: